Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: stdcm: stop awaiting the log entry creation #10453

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

editoast: stdcm: stop awaiting the log entry creation #10453

wants to merge 1 commit into from
+1 −2

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Jan 20, 2025

Fixes part of #10452

@Khoyo Khoyo requested a review from a team as a code owner January 20, 2025 17:23
leovalais
leovalais approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 20, 2025
@Khoyo
editoast: stdcm: stop awaiting the log entry creation
e001ec7 
Signed-off-by: Younes Khoudli <younes.khoudli@epita.fr>
@Khoyo Khoyo force-pushed the yk/dont-await-after-spawn branch from c33dc61 to e001ec7 Compare January 20, 2025 17:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (b828d20) to head (e001ec7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10453      +/-   ##
==========================================
- Coverage   81.78%   81.78%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106580   106579       -1     
  Branches      731      731              
==========================================
- Hits        87167    87162       -5     
- Misses      19374    19378       +4     
  Partials       39       39
Flag Coverage Δ
editoast 74.21% <100.00%> (-0.02%) ⬇️
front 89.34% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flomonster
flomonster approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch (not tested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Khoyo @codecov-commenter @flomonster @leovalais